-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MM-60420: treat bots as participants #1939
Conversation
49c5698
to
d73826c
Compare
WHERE i2.Id = i.Id | ||
AND rp.IsParticipant = true | ||
AND rp.UserId NOT IN (SELECT UserId FROM Bots) | ||
), '' | ||
ORDER BY (CASE WHEN b.UserId IS NULL THEN 0 ELSE 1 END), rp.UserId |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still JOIN so we can order bots after human participants.
// GetHistoricalPlaybookRunParticipantsCount returns the count of all members of a playbook run's channel | ||
// since the beginning of the playbook run, excluding bots. | ||
// since the beginning of the playbook run. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this is effectively "retroactive."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @lieut-data; I was wondering what was the reasoning behind preventing bots to become participants in the first place?
The driving impetus in the past was to prevent the |
Summary
In support of the MS Teams Tab App, and to unlock other security workflows involving bot participation in runs, let's allow bots to be participants of playbook runs.
Ticket Link
Fixes: https://mattermost.atlassian.net/browse/MM-60420